paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 13:33:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

markdown: Remove redundant checks from /me.

Browse Source 
If a message begins with /me, we do not have any cases where the
rendered content would not begin with `<p>/me`. Thus, we can safely
remove the redundant checks both on the backend and frontend.
This commit is contained in:
Rohitt Vashishtha
2019-12-03 19:59:44 +05:30
committed by Tim Abbott
parent 3df18c365d
commit 85c669e366
5 changed files with 11 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
frontend_tests/node_tests/compose.js
View File

@@ -1503,10 +1503,9 @@ run_test('on_events', () => {
};
}
function setup_mock_markdown_is_status_message(msg_content, msg_rendered, return_val) {
markdown.is_status_message = function (content, rendered) {
function setup_mock_markdown_is_status_message(msg_content, return_val) {
markdown.is_status_message = function (content) {
assert.equal(content, msg_content);
assert.equal(rendered, msg_rendered);
return return_val;
};
}
@@ -1572,7 +1571,7 @@ run_test('on_events', () => {
$("#compose-textarea").val('```foobarfoobar```');
setup_visibilities();
setup_mock_markdown_contains_backend_only_syntax('```foobarfoobar```', true);
setup_mock_markdown_is_status_message('```foobarfoobar```', 'Server: foobarfoobar', false);
setup_mock_markdown_is_status_message('```foobarfoobar```', false);
loading.make_indicator = function (spinner) {
assert.equal(spinner.selector, "#markdown_preview_spinner");
make_indicator_called = true;
@@ -1588,7 +1587,7 @@ run_test('on_events', () => {
$("#compose-textarea").val('foobarfoobar');
setup_visibilities();
setup_mock_markdown_contains_backend_only_syntax('foobarfoobar', false);
setup_mock_markdown_is_status_message('foobarfoobar', 'Server: foobarfoobar', false);
setup_mock_markdown_is_status_message('foobarfoobar', false);
mock_channel_post('foobarfoobar');
markdown.apply_markdown = function (msg) {
assert.equal(msg.raw_content, 'foobarfoobar');