Move feature_flags into its own file.

(imported from commit b775f85a24422d236b0079810b98b6b984cb60a2)

humbug/settings.py

@@ -361,6 +361,7 @@ JS_SPECS = {
                 if PIPELINE
                 else 'third/handlebars/handlebars.js'),
 
+            'js/feature_flags.js',
             'js/util.js',
             'js/setup.js',
             'js/viewport.js',

static/js/feature_flags.js

@@ -0,0 +1,10 @@
+var feature_flags = (function () {
+
+var exports = {};
+
+exports.always_open_compose = page_params.staging;
+exports.mark_read_at_bottom = page_params.staging;
+
+return exports;
+
+}());

static/js/zephyr.js

@@ -1,11 +1,3 @@
-var feature_flags = {};
-_.each([
-    'always_open_compose',
-    'mark_read_at_bottom'
-], function (key) {
-    feature_flags[key] = page_params.staging;
-});
-
 var all_msg_list = new MessageList();
 var home_msg_list = new MessageList('zhome', new narrow.Filter([["in", "home"]]));
 var narrowed_msg_list;

tools/jslint/check-all.js

@@ -25,7 +25,7 @@ var globals =
     + ' composebox_typeahead typeahead_helper notifications hashchange'
     + ' invite ui util activity timerender MessageList blueslip unread stream_list'
     + ' onboarding message_edit tab_bar emoji popovers navigate message_tour'
-    + ' avatar'
+    + ' avatar feature_flags'
 
     // colorspace.js
     + ' colorspace'
@@ -38,7 +38,7 @@ var globals =
 
     // zephyr.js
     + ' all_msg_list home_msg_list narrowed_msg_list current_msg_list get_updates_params'
-    + ' feature_flags add_messages'
+    + ' add_messages'
     + ' subject_dict people_dict'
     + ' keep_pointer_in_view move_pointer_at_page_top_and_bottom'
     + ' respond_to_message recenter_view last_viewport_movement_direction'