paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-07 15:33:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reintroduce composebox animation.

Browse Source 
So what's now happening here is that the outer div (which we were
previously animating) doesn't get animated at all; instead it is
simply made visible or hidden.

I *believe* this means that it always continues to take the same
amount of space in the DOM; its being added and removed seemed to
cause a slight height-of-page change which caused the scrollHandler to
fire, causing the selected message indicator to move down the page.

So now that this height is fixed, we achieve the animation instead by
animating the inner div -- the one that actually contains the
composebox elements.

(imported from commit 95b2f95d52254e3792633460f42efaac27559efe)
This commit is contained in:
Waseem Daher
2012-10-09 14:11:44 -04:00
parent 8083a149b8
commit 86dfc93f96
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
zephyr/static/js/compose.js
View File

@@ -2,6 +2,7 @@ var status_classes = 'alert-error alert-success alert-info';
function show_compose(tabname, focus_area) {
$('#zephyr_compose').css({visibility: "visible"});
$('.zephyr_comp').slideDown(100);
$('#zephyr-type-tabs a[href="#' + tabname + '-message"]').tab('show');
focus_area.focus();
focus_area.select();
@@ -9,7 +10,8 @@ function show_compose(tabname, focus_area) {
function hide_compose() {
$('input, textarea, button').blur();
$('#zephyr_compose').css({visibility: "hidden"});
$('.zephyr_comp').slideUp(100,
function() { $('#zephyr_compose').css({visibility: "hidden"});});
}
function clear_compose_box() {