paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 13:03:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

recent_topics: Split into three modules.

Browse Source 
We split recent_topics module into recent_topics_(ui + data + util).

This allows us to reduce cyclical dependencies which were
created due to large list of imports in recent topics. Also, this
refactor on its own makes sense.
This commit is contained in:
Aman Agrawal
2021-06-10 12:18:46 +00:00
committed by Tim Abbott
parent eb1d8b1a96
commit 88454307cd
29 changed files with 194 additions and 178 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
static/js/message_events.js
View File

@@ -20,7 +20,7 @@ import * as notifications from "./notifications";
import {page_params} from "./page_params";
import * as pm_list from "./pm_list";
import * as recent_senders from "./recent_senders";
import * as recent_topics from "./recent_topics";
import * as recent_topics_ui from "./recent_topics_ui";
import * as resize from "./resize";
import * as stream_list from "./stream_list";
import * as stream_topic_history from "./stream_topic_history";
@@ -132,7 +132,7 @@ export function insert_new_messages(messages, sent_by_this_client) {
notifications.received_messages(messages);
stream_list.update_streams_sidebar();
pm_list.update_private_messages();
recent_topics.process_messages(messages);
recent_topics_ui.process_messages(messages);
}
export function update_messages(events) {
@@ -399,7 +399,7 @@ export function update_messages(events) {
new_stream_id: post_edit_stream_id,
new_topic: post_edit_topic,
});
recent_topics.process_topic_edit(...args);
recent_topics_ui.process_topic_edit(...args);
}
// Rerender "Message edit history" if it was open to the edited message.
@@ -456,5 +456,5 @@ export function remove_messages(message_ids) {
list.remove_and_rerender(message_ids);
}
recent_senders.update_topics_of_deleted_message_ids(message_ids);
recent_topics.update_topics_of_deleted_message_ids(message_ids);
recent_topics_ui.update_topics_of_deleted_message_ids(message_ids);
}