paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 06:53:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Cleanup the existence of fraction_present.

Browse Source 
Replacing the group PMs icon with "fa fa-group" icon
drops the color class "fraction_present" logic. As there
is no more use of fraction_present class this commit
cleanups its all existence from the codebase.
This commit is contained in:
Nikhil Maske
2021-04-30 22:57:06 +05:30
committed by Tim Abbott
parent b7fb130578
commit 88856f58c5
2 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
frontend_tests/node_tests/pm_list.js
View File

@@ -95,7 +95,6 @@ test("build_private_messages_list", (override) => {
is_active: false, is_active: false,
url: "#narrow/pm-with/101,102-group", url: "#narrow/pm-with/101,102-group",
user_circle_class: "user_circle_fraction", user_circle_class: "user_circle_fraction",
fraction_present: undefined,
is_group: true, is_group: true,
}, },
]; ];
@@ -136,7 +135,6 @@ test("build_private_messages_list_bot", (override) => {
is_active: false, is_active: false,
url: "#narrow/pm-with/314-outgoingwebhook", url: "#narrow/pm-with/314-outgoingwebhook",
user_circle_class: "user_circle_green", user_circle_class: "user_circle_green",
fraction_present: undefined,
is_group: false, is_group: false,
}, },
{ {
@@ -147,7 +145,6 @@ test("build_private_messages_list_bot", (override) => {
is_active: false, is_active: false,
url: "#narrow/pm-with/101,102-group", url: "#narrow/pm-with/101,102-group",
user_circle_class: "user_circle_fraction", user_circle_class: "user_circle_fraction",
fraction_present: undefined,
is_group: true, is_group: true,
}, },
]; ];

3
static/js/pm_list.js
View File

@@ -75,11 +75,9 @@ export function _get_convos() {
const is_active = user_ids_string === active_user_ids_string; const is_active = user_ids_string === active_user_ids_string;
let user_circle_class; let user_circle_class;
let fraction_present;
if (is_group) { if (is_group) {
user_circle_class = "user_circle_fraction"; user_circle_class = "user_circle_fraction";
fraction_present = buddy_data.huddle_fraction_present(user_ids_string);
} else { } else {
const user_id = Number.parseInt(user_ids_string, 10); const user_id = Number.parseInt(user_ids_string, 10);
user_circle_class = buddy_data.get_user_circle_class(user_id); user_circle_class = buddy_data.get_user_circle_class(user_id);
@@ -98,7 +96,6 @@ export function _get_convos() {
is_active, is_active,
url: hash_util.pm_with_uri(reply_to), url: hash_util.pm_with_uri(reply_to),
user_circle_class, user_circle_class,
fraction_present,
is_group, is_group,
}; };
display_messages.push(display_message); display_messages.push(display_message);