paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-17 12:21:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

modal: Add support for linking the submit button to a form element.

Browse Source
This commit is contained in:
Ganesh Pawar
2021-11-21 20:33:10 +05:30
committed by Tim Abbott
parent eef9dd963b
commit 8908ea99ec
2 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
static/js/dialog_widget.js
View File

@@ -80,6 +80,7 @@ export function launch(conf) {
// * help_link: A help link in the heading area. // * help_link: A help link in the heading area.
// * id: Custom id to the container element to modify styles. // * id: Custom id to the container element to modify styles.
// * single_footer_button: If true, don't include the "Cancel" button. // * single_footer_button: If true, don't include the "Cancel" button.
// * form_id: Id of the form element in the modal if it exists.
for (const f of mandatory_fields) { for (const f of mandatory_fields) {
if (conf[f] === undefined) { if (conf[f] === undefined) {
@@ -110,6 +111,14 @@ export function launch(conf) {
} }
const submit_button = dialog.find(".dialog_submit_button"); const submit_button = dialog.find(".dialog_submit_button");
// This is used to link the submit button with the form, if present, in the modal.
// This makes it so that submitting this form by pressing Enter on an input element
// triggers a click on the submit button.
if (conf.form_id) {
submit_button.attr("form", conf.form_id);
}
// Set up handlers. // Set up handlers.
submit_button.on("click", (e) => { submit_button.on("click", (e) => {
if (conf.loading_spinner) { if (conf.loading_spinner) {

5
static/js/settings_bots.js
View File

@@ -433,14 +433,11 @@ export function set_up() {
$(".edit_bot_form").trigger("submit"); $(".edit_bot_form").trigger("submit");
}, },
post_render: edit_bot_post_render, post_render: edit_bot_post_render,
form_id: "edit_bot_form",
loading_spinner: true, loading_spinner: true,
}); });
function edit_bot_post_render() { function edit_bot_post_render() {
// This links the submit button to the edit bot form, so submitting this form
// by pressing Enter on an input element triggers a click on the submit button.
$("#edit_bot_modal .dialog_submit_button").attr("form", "edit_bot_form");
const avatar_widget = avatar.build_bot_edit_widget($(".edit_bot_form")); const avatar_widget = avatar.build_bot_edit_widget($(".edit_bot_form"));
const form = $(".edit_bot_form"); const form = $(".edit_bot_form");
const image = li.find(".image"); const image = li.find(".image");