paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 04:53:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

node_tests: Don’t read from most deprecated global variables.

Browse Source 
We still need to write to these globals with set_global because the
code being tested reads from them, but the tests themselves should
never need to read from them.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg
2021-02-09 19:53:22 -08:00
parent 34e37cea1c
commit 89aa3155a9
110 changed files with 407 additions and 399 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
frontend_tests/node_tests/stream_list.js
View File

@@ -11,16 +11,16 @@ set_global("document", "document-stub");
set_global("$", make_zjquery());
zrequire("unread_ui");
zrequire("Filter", "js/filter");
zrequire("stream_sort");
const Filter = zrequire("Filter", "js/filter");
const stream_sort = zrequire("stream_sort");
zrequire("colorspace");
zrequire("stream_color");
const stream_color = zrequire("stream_color");
zrequire("hash_util");
zrequire("unread");
zrequire("stream_data");
zrequire("scroll_util");
const unread = zrequire("unread");
const stream_data = zrequire("stream_data");
const scroll_util = zrequire("scroll_util");
zrequire("list_cursor");
zrequire("stream_list");
const stream_list = zrequire("stream_list");
zrequire("topic_zoom");
zrequire("ui");
set_global("page_params", {
@@ -38,7 +38,7 @@ const return_true = function () {
return true;
};
set_global("topic_list", {});
const topic_list = set_global("topic_list", {});
set_global("overlays", {});
set_global("popovers", {});
@@ -387,10 +387,11 @@ run_test("zoom_in_and_zoom_out", () => {
set_global("$", make_zjquery());
let narrow_state;
run_test("narrowing", () => {
initialize_stream_data();
set_global("narrow_state", {
narrow_state = set_global("narrow_state", {
stream() {
return "devel";
},