paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-31 12:03:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

topic_list: Limit number of unread topics shown at once.

Browse Source 
This avoids a stream having potentially near-infinite height when
opened in a stream with a large number of unread topics; the benefit
is that you can easily access the next stream.

We show an unread count next to "more topics" to make it hard to miss
that there might be more, older topics with unread messages.

With CSS work by Anders Kaseorg.

Fixes #13087.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
This commit is contained in:
Tim Abbott
2019-08-28 16:41:23 -07:00
parent 1dfbeaf05b
commit 89ff62dafa
4 changed files with 114 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
static/js/stream_list.js
View File

@@ -317,9 +317,22 @@ exports.update_dom_with_unread_counts = function (counts) {
// counts.topic_count maps streams to hashes of topics to counts
counts.topic_count.each(function (topic_hash, stream_id) {
// Because the topic_list data structure doesn't keep track of
// which topics the "more topics" unread count came from, we
// need to compute the correct value from scratch here.
let more_topics_total = 0;
topic_hash.each(function (count, topic) {
topic_list.set_count(stream_id, topic, count);
const in_more_topics = topic_list.set_count(stream_id, topic, count);
if (in_more_topics === true) {
more_topics_total += count;
}
});
if (topic_list.active_stream_id() === stream_id) {
// Update the "more topics" unread count; we communicate
// this to the `topic_list` library by passing `null` as
// the topic.
topic_list.set_count(stream_id, null, more_topics_total);
}
});
};