paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-09 08:26:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

compose: Change stream field in composebox to be a dropdown.

Browse Source 
Fixes #11832

This lets the user see more options than the three that appear
in the typeahead menu, and prevents them from inputting invalid
stream names.

This change replaces the input field with the dropdown, and
updates everything that referred to the classnames of the old
input field, so that they now get the data they need from the
new dropdown.
This commit is contained in:
evykassirer
2022-10-20 15:44:55 -07:00
committed by Tim Abbott
parent 429f23fc4f
commit 8a2455a294
25 changed files with 381 additions and 169 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
web/src/compose.js
View File

@@ -445,12 +445,14 @@ export function render_and_show_preview($preview_spinner, $preview_content_box,
export function initialize() {
$("#below-compose-content .video_link").toggle(compute_show_video_chat_button());
$(
"#stream_message_recipient_stream,#stream_message_recipient_topic,#private_message_recipient",
).on("keyup", update_on_recipient_change);
$(
"#stream_message_recipient_stream,#stream_message_recipient_topic,#private_message_recipient",
).on("change", () => {
// `keyup` isn't relevant for streams since it registers as a change only
// when an item in the dropdown is selected.
$("#stream_message_recipient_topic,#private_message_recipient").on(
"keyup",
update_on_recipient_change,
);
// changes for the stream dropdown are handled in on_compose_select_stream_update
$("#stream_message_recipient_topic,#private_message_recipient").on("change", () => {
update_on_recipient_change();
compose_state.set_recipient_edited_manually(true);
});
@@ -516,7 +518,7 @@ export function initialize() {
event.preventDefault();
const stream_name = compose_state.stream_name();
if (stream_name === undefined) {
if (stream_name === "") {
return;
}
const sub = stream_data.get_sub(stream_name);