paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-18 04:43:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

bug fix: Handle bad streams for compose-invite feature.

Browse Source 
We now handle missing subs more gracefully when you click on the
link to invite somebody you at-mentioned in a stream message.
This commit is contained in:
Steve Howell
2017-03-04 14:02:59 -08:00
committed by Tim Abbott
parent 6183a0d8b2
commit 8a4dee4a80
1 changed files with 18 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
static/js/compose.js
View File

@@ -974,19 +974,34 @@ $(function () {
return;
}
subs.invite_user_to_stream(email, compose.stream_name(), function () {
function success() {
var all_invites = $("#compose_invite_users");
invite_row.remove();
if (all_invites.children().length === 0) {
all_invites.hide();
}
}, function () {
}
function failure() {
var error_msg = invite_row.find('.compose_invite_user_error');
error_msg.show();
$(event.target).attr('disabled', true);
});
}
var stream_name = compose.stream_name();
var sub = stream_data.get_sub(stream_name);
if (!sub) {
// This should only happen if a stream rename occurs
// before the user clicks. We could prevent this by
// putting a stream id in the link.
blueslip.warn('Stream no longer exists: ' + stream_name);
failure();
return;
}
subs.invite_user_to_stream(email, sub.name, success, failure);
});
$("#compose_invite_users").on('click', '.compose_invite_close', function (event) {