message_edit: Fix "(deleted)" not showing for empty edited DMs.

This commit fixes a bug introduced in commit `37f2c5bc788`,
where a message in DM is not updated to "(deleted)" when
left empty after editing.

Fixes: #33305
This commit is contained in:
whilstsomebody
2025-02-03 19:47:11 +05:30
committed by Tim Abbott
parent 21412b9f79
commit 8a64940868
2 changed files with 24 additions and 10 deletions

View File

@@ -1262,16 +1262,6 @@ def build_message_edit_request(
topic_name: str | None = None,
content: str | None = None,
) -> StreamMessageEditRequest | DirectMessageEditRequest:
if not message.is_stream_message():
# We have already validated the code to have content
# as not None.
assert content is not None
return DirectMessageEditRequest(
content=content,
orig_content=message.content,
is_content_edited=True,
)
is_content_edited = False
new_content = message.content
if content is not None:
@@ -1280,6 +1270,15 @@ def build_message_edit_request(
content = "(deleted)"
new_content = normalize_body(content)
if not message.is_stream_message():
# We have already validated that at least one of content, topic, or stream
# must be modified, and for DMs, only the content can be edited.
return DirectMessageEditRequest(
content=new_content,
orig_content=message.content,
is_content_edited=True,
)
is_topic_edited = False
topic_resolved = False
topic_unresolved = False