paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 14:03:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Cache realm alert_words to avoid database hits when rendering

Browse Source 
We found that since bugdown processes are threaded, the cost of
doing a db query in a markdown processor is quite high---each
thread must start up a new db connection including a SSL handshake
etc. We should strive to keep our rendering pipeline free of mandatory
DB queries.

(imported from commit 555066bd03da6c681b74ce6137acc264eb41c55d)
This commit is contained in:
Leo Franchi
2013-09-06 14:50:25 -04:00
parent 7b375634f9
commit 8ad6a0daa9
2 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
zerver/lib/alert_words.py
View File

@@ -2,10 +2,13 @@ import re
import zerver.models import zerver.models
from zerver.lib.cache import cache_with_key, realm_alert_words_cache_key
import itertools import itertools
import logging import logging
import ujson import ujson
@cache_with_key(realm_alert_words_cache_key, timeout=3600*24)
def alert_words_in_realm(realm): def alert_words_in_realm(realm):
users = zerver.models.UserProfile.objects.filter(realm=realm, is_active=True) users = zerver.models.UserProfile.objects.filter(realm=realm, is_active=True)
all_user_words = dict((user, user_alert_words(user)) for user in users) all_user_words = dict((user, user_alert_words(user)) for user in users)

8
zerver/lib/cache.py
View File

@@ -242,6 +242,11 @@ def update_user_profile_cache(sender, **kwargs):
items_for_memcached[user_profile_by_id_cache_key(user_profile.id)] = (user_profile,) items_for_memcached[user_profile_by_id_cache_key(user_profile.id)] = (user_profile,)
cache_set_many(items_for_memcached) cache_set_many(items_for_memcached)
# Invalidate realm-wide alert words cache if any user in the realm has changed
# alert words
if kwargs['update_fields'] is None or "alert_words" in kwargs['update_fields']:
djcache.delete(KEY_PREFIX + realm_alert_words_cache_key(user_profile.realm))
def status_dict_cache_key(user_profile): def status_dict_cache_key(user_profile):
return "status_dict:%d" % (user_profile.realm_id,) return "status_dict:%d" % (user_profile.realm_id,)
@@ -251,3 +256,6 @@ def update_user_presence_cache(sender, **kwargs):
# If the status of the user changed, flush the user's realm's # If the status of the user changed, flush the user's realm's
# entry in the UserPresence cache to avoid giving out stale state # entry in the UserPresence cache to avoid giving out stale state
djcache.delete(KEY_PREFIX + status_dict_cache_key(user_profile)) djcache.delete(KEY_PREFIX + status_dict_cache_key(user_profile))
def realm_alert_words_cache_key(realm):
return "realm_alert_words:%s" % (realm.domain,)