paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 14:03:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

info_overlay: Make them overlays from quasi-overlays.

Browse Source 
We always use hashchange.go_to_location method now to open the
info_overlay, this makes sure that the url hash are reliable and
hotkeys don't get confused if an overlay is open or not.

We don't want to change hash to "" (this also doesn't navigates
us to 'All messages' view, hence the bug was not noticed.) on
exit of info_overlay.
This commit is contained in:
Aman Agrawal
2020-07-02 15:37:30 +05:30
committed by Tim Abbott
parent 87d8a54b91
commit 8b29c38e62
7 changed files with 25 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
static/js/click_handlers.js
View File

@@ -673,7 +673,7 @@ exports.initialize = function () {
$("body").on("click", "[data-overlay-trigger]", function () {
const target = $(this).attr("data-overlay-trigger");
info_overlay.show(target);
hashchange.go_to_location(target);
});
function handle_compose_click(e) {