paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

todo widget: Avoid completed/pending complexity.

Browse Source 
We now only compute these two sublists when we
need them, rather than having to splice and
unshift them every time.
This commit is contained in:
Steve Howell
2020-04-08 11:04:47 +00:00
committed by showell
parent 31a5119892
commit 8c73375f10
1 changed files with 10 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
static/js/todo_widget.js
View File

@@ -5,11 +5,19 @@ exports.task_data_holder = function () {
const self = {}; const self = {};
const all_tasks = []; const all_tasks = [];
const pending_tasks = [];
const completed_tasks = [];
let my_idx = 1; let my_idx = 1;
self.get_widget_data = function () { self.get_widget_data = function () {
const pending_tasks = [];
const completed_tasks = [];
for (const item of all_tasks) {
if (item.completed) {
completed_tasks.push(item);
} else {
pending_tasks.push(item);
}
}
const widget_data = { const widget_data = {
pending_tasks: pending_tasks, pending_tasks: pending_tasks,
@@ -64,7 +72,6 @@ exports.task_data_holder = function () {
}; };
if (!self.check_task.task_exists(task)) { if (!self.check_task.task_exists(task)) {
pending_tasks.push(task_data);
all_tasks.push(task_data); all_tasks.push(task_data);
if (my_idx <= idx) { if (my_idx <= idx) {
@@ -96,17 +103,6 @@ exports.task_data_holder = function () {
} }
all_tasks[task_index].completed = !all_tasks[task_index].completed; all_tasks[task_index].completed = !all_tasks[task_index].completed;
// toggle
if (task.completed) {
index = pending_tasks.indexOf(task);
pending_tasks.splice(index, 1);
completed_tasks.unshift(task);
} else {
index = completed_tasks.indexOf(task);
completed_tasks.splice(index, 1);
pending_tasks.push(task);
}
}, },
}, },
}; };