paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

settings: Refactor notifications update_page to use switch.

Browse Source 
Changes suggested by timabbott: https://github.com/zulip/zulip/pull/19944#discussion_r727565978

Facilitates additional changes for issue #19713.
This commit is contained in:
Andrew McAfee
2021-10-23 15:15:36 +00:00
committed by Tim Abbott
parent c8badbd858
commit 8c7e144e47
1 changed files with 23 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
static/js/settings_notifications.js
View File

@@ -173,25 +173,30 @@ export function update_page(settings_panel) {
const container = $(settings_panel.container);
const settings_object = settings_panel.settings_object;
for (const setting of settings_config.all_notification_settings) {
if (
setting === "enable_offline_push_notifications" &&
!page_params.realm_push_notifications_enabled
) {
// If push notifications are disabled at the realm level,
// we should just leave the checkbox always off.
continue;
} else if (setting === "desktop_icon_count_display") {
update_desktop_icon_count_display(settings_panel);
continue;
} else if (
setting === "notification_sound" ||
setting === "email_notifications_batching_period_seconds"
) {
container.find(`.setting_${CSS.escape(setting)}`).val(settings_object[setting]);
continue;
switch (setting) {
case "enable_offline_push_notifications": {
if (!page_params.realm_push_notifications_enabled) {
// If push notifications are disabled at the realm level,
// we should just leave the checkbox always off.
break;
}
container.find(`.${CSS.escape(setting)}`).prop("checked", settings_object[setting]);
break;
}
case "desktop_icon_count_display": {
update_desktop_icon_count_display(settings_panel);
break;
}
case "notification_sound":
case "email_notifications_batching_period_seconds": {
container.find(`.setting_${CSS.escape(setting)}`).val(settings_object[setting]);
break;
}
default: {
container.find(`.${CSS.escape(setting)}`).prop("checked", settings_object[setting]);
break;
}
}
container.find(`.${CSS.escape(setting)}`).prop("checked", settings_object[setting]);
}
rerender_ui();
}