paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-01 20:44:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

python: Convert more variable type annotations to Python 3.6 style.

Browse Source 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg
2020-05-08 15:10:17 -07:00
committed by Tim Abbott
parent 708c6f4f11
commit 8cdf2801f7
17 changed files with 122 additions and 113 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
docs/tutorials/new-feature-tutorial.md
View File

@@ -173,9 +173,9 @@ boolean field, `mandatory_topics`, to the Realm model in
class Realm(models.Model):
# ...
emails_restricted_to_domains = models.BooleanField(default=True) # type: bool
invite_required = models.BooleanField(default=False) # type: bool
+ mandatory_topics = models.BooleanField(default=False) # type: bool
emails_restricted_to_domains: bool = models.BooleanField(default=True)
invite_required: bool = models.BooleanField(default=False)
+ mandatory_topics: bool = models.BooleanField(default=False)
```
The Realm model also contains an attribute, `property_types`, which
@@ -405,12 +405,15 @@ annotation).
# zerver/views/realm.py
def update_realm(request, user_profile, name=REQ(validator=check_string, default=None),
# ...,
+ mandatory_topics=REQ(validator=check_bool, default=None),
# ...):
+ # type: (HttpRequest, UserProfile, ..., Optional[bool], ...
# ...
def update_realm(
request: HttpRequest,
user_profile: UserProfile,
name: Optional[str] = REQ(validator=check_string, default=None),
# ...
+ mandatory_topics: Optional[bool] = REQ(validator=check_bool, default=None),
# ...
):
# ...
```
If this feature fits the `property_types` framework and does