paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 14:03:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

compose: Migrate compose-all-everyone to use compose_banner.

Browse Source 
This is part several updates for #22524.

Testing note: I removed the test test_compose_all_everyone_confirm_clicked
since it heavily relies on the old way of rendering banners and is too
UI-focused (instead of logic focused) for me to feel like it's worth
testing that the banner is removed when clicking the button.
This commit is contained in:
evykassirer
2022-08-20 12:07:32 -07:00
committed by Tim Abbott
parent ab5d088188
commit 8ced075643
12 changed files with 63 additions and 100 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
static/js/compose.js
View File

@@ -450,14 +450,16 @@ export function initialize() {
upload.feature_check($("#compose .compose_upload_file"));
$("#compose-all-everyone").on("click", ".compose-all-everyone-confirm", (event) => {
event.preventDefault();
$(event.target).parents(".compose-all-everyone").remove();
compose_validate.set_user_acknowledged_all_everyone_flag(true);
compose_validate.clear_all_everyone_warnings();
finish();
});
$("#compose_banners").on(
"click",
`.${compose_error.CLASSNAMES.wildcard_warning} .compose_banner_action_button`,
(event) => {
event.preventDefault();
compose_validate.clear_wildcard_warnings();
compose_validate.set_user_acknowledged_wildcard_flag(true);
finish();
},
);
$("#compose-send-status").on("click", ".sub_unsub_button", (event) => {
event.preventDefault();