paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-05 14:35:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

message_util: Avoid unnecessary unreads work processing new messages.

Browse Source 
It should be very rare to discover new unread messages during a
message_fetch call. This can potentially happen due to races (fetching
just as a new message arrives), but it shouldn't be the common case.

Previously, we would trigger a full rerender of all UI displaying
unread messages every time a bulk message fetch operation returned
(including every time one narrowed), regardless of whether any actual
state had changed.

Fix this by actually checking if we discovered any new unread messages.
This commit is contained in:
Tim Abbott
2022-10-24 15:34:47 -07:00
parent 505a9119ba
commit 8d33a62eca
6 changed files with 55 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
static/js/message_fetch.js
View File

@@ -49,16 +49,9 @@ function process_result(data, opts) {
messages = messages.map((message) => message_helper.process_new_message(message));
// In case any of the newly fetched messages are new, add them to
// our unread data structures. It's important that this run even
// when fetching in a narrow, since we might return unread
// messages that aren't in the home view data set (e.g. on a muted
// stream).
//
// BUG: This code path calls pm_list.update_private_messages, even
// if there were no private messages (or even no new messages at
// all) in data.messages, which is a waste of resources.
message_util.do_unread_count_updates(messages);
// In some rare situations, we expect to discover new unread
// messages not tracked in unread.js during this fetching process.
message_util.do_unread_count_updates(messages, true);
// If we're loading more messages into the home view, save them to
// the all_messages_data as well, as the message_lists.home is