paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

eslint: Fix unicorn/no-this-assignment.

Browse Source 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg
2021-01-22 17:52:49 -08:00
committed by Tim Abbott
parent a679ee12f3
commit 8d44cd78ec
2 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
frontend_tests/node_tests/narrow_activate.js
View File

@@ -117,11 +117,10 @@ function test_helper() {
function stub_message_list() {
message_list.MessageList = function (opts) {
const list = this;
this.data = opts.data;
this.view = {
set_message_offset(offset) {
list.view.offset = offset;
this.offset = offset;
},
};

9
static/js/composebox_typeahead.js
View File

@@ -528,8 +528,7 @@ exports.get_sorted_filtered_items = function (query) {
several years ago.)
*/
const hacky_this = this;
const fetcher = exports.get_candidates.bind(hacky_this);
const fetcher = exports.get_candidates.bind(this);
const big_results = fetcher(query);
if (!big_results) {
@@ -538,10 +537,10 @@ exports.get_sorted_filtered_items = function (query) {
// We are still hacking info onto the "this" from
// bootstrap. Yuck.
const completing = hacky_this.completing;
const token = hacky_this.token;
const completing = this.completing;
const token = this.token;
const opts = exports.get_stream_topic_data(hacky_this);
const opts = exports.get_stream_topic_data(this);
if (completing === "mention" || completing === "silent_mention") {
return exports.filter_and_sort_mentions(big_results.is_silent, token, opts);