paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 06:53:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

cache_helpers: Fill to_dict cache instead of old message cache.

Browse Source 
Apparently, the message cache we were filling was completely useless
and unused, and furthermore, the cache we were filling as part of
restarting the server was also totally useless, since it didn't have
the messages users would be requesting.
This commit is contained in:
Tim Abbott
2016-07-07 17:28:36 -07:00
committed by Rishi Gupta
parent 704c57a141
commit 8d5ec14b31
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
zerver/lib/cache_helpers.py
View File

@@ -9,7 +9,7 @@ from typing import Any, Dict, Callable, Tuple
from django.conf import settings from django.conf import settings
from zerver.models import Message, UserProfile, Stream, get_stream_cache_key, \ from zerver.models import Message, UserProfile, Stream, get_stream_cache_key, \
Recipient, get_recipient_cache_key, Client, get_client_cache_key, \ Recipient, get_recipient_cache_key, Client, get_client_cache_key, \
Huddle, huddle_hash_cache_key Huddle, huddle_hash_cache_key, to_dict_cache_key_id, stringify_message_dict
from zerver.lib.cache import cache_with_key, cache_set, message_cache_key, \ from zerver.lib.cache import cache_with_key, cache_set, message_cache_key, \
user_profile_by_email_cache_key, user_profile_by_id_cache_key, \ user_profile_by_email_cache_key, user_profile_by_id_cache_key, \
get_remote_cache_time, get_remote_cache_requests, cache_set_many get_remote_cache_time, get_remote_cache_requests, cache_set_many
@@ -40,7 +40,7 @@ def message_fetch_objects():
def message_cache_items(items_for_remote_cache, message): def message_cache_items(items_for_remote_cache, message):
# type: (Dict[text_type, Tuple[Message]], Message) -> None # type: (Dict[text_type, Tuple[Message]], Message) -> None
items_for_remote_cache[message_cache_key(message.id)] = (message,) items_for_remote_cache[to_dict_cache_key_id(message.id, True)] = (stringify_message_dict(message.to_dict_uncached(True)),)
def user_cache_items(items_for_remote_cache, user_profile): def user_cache_items(items_for_remote_cache, user_profile):
# type: (Dict[text_type, Tuple[UserProfile]], UserProfile) -> None # type: (Dict[text_type, Tuple[UserProfile]], UserProfile) -> None