paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-23 04:52:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

compose: Move closed-compose functions to closed_compose_ui.js.

Browse Source 
This improves the organization of our codebase a bit.
This commit is contained in:
Tim Abbott
2021-05-11 13:04:35 -07:00
parent 9239de408a
commit 8e7761e15b
7 changed files with 46 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
frontend_tests/node_tests/compose.js
View File

@@ -87,6 +87,7 @@ document.location.host = "foo.com";
const fake_now = 555;
MockDate.set(new Date(fake_now * 1000));
const compose_closed_ui = zrequire("compose_closed_ui");
const compose_fade = zrequire("compose_fade");
const peer_data = zrequire("peer_data");
const util = zrequire("util");
@@ -1767,7 +1768,7 @@ test_ui("create_message_object", (override) => {
test_ui("narrow_button_titles", () => {
util.is_mobile = () => false;
compose.update_closed_compose_buttons_for_private();
compose_closed_ui.update_buttons_for_private();
assert.equal(
$("#left_bar_compose_stream_button_big").text(),
$t({defaultMessage: "New stream message"}),
@@ -1777,7 +1778,7 @@ test_ui("narrow_button_titles", () => {
$t({defaultMessage: "New private message"}),
);
compose.update_closed_compose_buttons_for_stream();
compose_closed_ui.update_buttons_for_stream();
assert.equal(
$("#left_bar_compose_stream_button_big").text(),
$t({defaultMessage: "New topic"}),

7
frontend_tests/node_tests/narrow_activate.js
View File

@@ -13,7 +13,6 @@ mock_esm("../../static/js/resize", {
const all_messages_data = mock_esm("../../static/js/all_messages_data");
const channel = mock_esm("../../static/js/channel");
const compose = mock_esm("../../static/js/compose");
const compose_actions = mock_esm("../../static/js/compose_actions");
const compose_closed_ui = mock_esm("../../static/js/compose_closed_ui");
const hashchange = mock_esm("../../static/js/hashchange");
@@ -94,8 +93,8 @@ function test_helper() {
stub(typing_events, "render_notifications_for_narrow");
stub(ui_util, "change_tab_to");
stub(unread_ops, "process_visible");
stub(compose, "update_closed_compose_buttons_for_stream");
stub(compose, "update_closed_compose_buttons_for_private");
stub(compose_closed_ui, "update_buttons_for_stream");
stub(compose_closed_ui, "update_buttons_for_private");
return {
clear: () => {
@@ -203,7 +202,7 @@ run_test("basics", () => {
[ui_util, "change_tab_to"],
[unread_ops, "process_visible"],
[hashchange, "save_narrow"],
[compose, "update_closed_compose_buttons_for_stream"],
[compose_closed_ui, "update_buttons_for_stream"],
[compose_closed_ui, "update_reply_recipient_label"],
[search, "update_button_visibility"],
[compose_actions, "on_narrow"],

5
frontend_tests/node_tests/recent_topics.js
View File

@@ -65,8 +65,9 @@ const ListWidget = mock_esm("../../static/js/list_widget", {
render_item: (item) => ListWidget.modifier(item),
});
mock_esm("../../static/js/compose", {
update_closed_compose_buttons_for_recent_topics: noop,
mock_esm("../../static/js/compose_closed_ui", {
set_standard_text_for_reply_button: noop,
update_buttons_for_recent_topics: noop,
});
mock_esm("../../static/js/hash_util", {
by_stream_uri: () => "https://www.example.com",