mirror of
				https://github.com/zulip/zulip.git
				synced 2025-11-04 14:03:30 +00:00 
			
		
		
		
	js: Fix no-jquery/no-ready-shorthand.
The ready method was deprecated in jQuery 3.0, because its behavior has nothing to do with the selector; it always waits for the page to become ready, not a specific element. Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
		
				
					committed by
					
						
						Tim Abbott
					
				
			
			
				
	
			
			
			
						parent
						
							da0658967c
						
					
				
				
					commit
					8ef2c0a604
				
			@@ -641,7 +641,7 @@ export function build_emoji_popover($elt, id) {
 | 
				
			|||||||
    };
 | 
					    };
 | 
				
			||||||
    show_emoji_catalog();
 | 
					    show_emoji_catalog();
 | 
				
			||||||
 | 
					
 | 
				
			||||||
    $elt.ready(() => refill_section_head_offsets($popover));
 | 
					    $(() => refill_section_head_offsets($popover));
 | 
				
			||||||
    register_popover_events($popover);
 | 
					    register_popover_events($popover);
 | 
				
			||||||
}
 | 
					}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 
 | 
				
			|||||||
@@ -22,7 +22,7 @@ import {user_settings} from "./user_settings";
 | 
				
			|||||||
 | 
					
 | 
				
			||||||
export let settings_label;
 | 
					export let settings_label;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
$("body").ready(() => {
 | 
					$(() => {
 | 
				
			||||||
    $("#settings_overlay_container").on("click", (e) => {
 | 
					    $("#settings_overlay_container").on("click", (e) => {
 | 
				
			||||||
        if (!overlays.is_modal_open()) {
 | 
					        if (!overlays.is_modal_open()) {
 | 
				
			||||||
            return;
 | 
					            return;
 | 
				
			||||||
 
 | 
				
			|||||||
		Reference in New Issue
	
	Block a user