paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 15:03:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Make acting_user a mandatory kwarg for do_change_default_sending_stream.

Browse Source
This commit is contained in:
shanukun
2021-04-08 14:20:37 +05:30
committed by Tim Abbott
parent 6b8dfc2888
commit 8f70386df3
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
zerver/lib/actions.py
View File

@@ -4114,7 +4114,7 @@ def do_change_plan_type(
def do_change_default_sending_stream( def do_change_default_sending_stream(
user_profile: UserProfile, stream: Optional[Stream], acting_user: Optional[UserProfile] = None user_profile: UserProfile, stream: Optional[Stream], *, acting_user: Optional[UserProfile]
) -> None: ) -> None:
old_value = user_profile.default_sending_stream_id old_value = user_profile.default_sending_stream_id
user_profile.default_sending_stream = stream user_profile.default_sending_stream = stream

4
zerver/tests/test_events.py
View File

@@ -1462,11 +1462,11 @@ class NormalActionsTest(BaseAction):
bot = self.create_bot("test") bot = self.create_bot("test")
stream = get_stream("Rome", bot.realm) stream = get_stream("Rome", bot.realm)
action = lambda: do_change_default_sending_stream(bot, stream) action = lambda: do_change_default_sending_stream(bot, stream, acting_user=None)
events = self.verify_action(action) events = self.verify_action(action)
check_realm_bot_update("events[0]", events[0], "default_sending_stream") check_realm_bot_update("events[0]", events[0], "default_sending_stream")
action = lambda: do_change_default_sending_stream(bot, None) action = lambda: do_change_default_sending_stream(bot, None, acting_user=None)
events = self.verify_action(action) events = self.verify_action(action)
check_realm_bot_update("events[0]", events[0], "default_sending_stream") check_realm_bot_update("events[0]", events[0], "default_sending_stream")