paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 15:03:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

settings: Refactor code to handle dropdown widgets.

Browse Source 
We now add a new function to set up the dropdown widget for
settings using new dropdown_widget.DropdownWidget instead of
calling dropdown_widget.DropdownWidget multiple times to
reduce code duplication.
This commit is contained in:
Sahil Batra
2024-06-11 17:32:35 +05:30
committed by Tim Abbott
parent 47b678a4ab
commit 901b216e7a
2 changed files with 86 additions and 205 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
web/tests/settings_org.test.js
View File

@@ -26,7 +26,6 @@ const settings_bots = zrequire("settings_bots");
const settings_account = zrequire("settings_account");
const settings_components = zrequire("settings_components");
const settings_org = zrequire("settings_org");
const dropdown_widget = zrequire("dropdown_widget");
function test(label, f) {
run_test(label, (helpers) => {
@@ -499,10 +498,7 @@ test("set_up", ({override, override_rewire}) => {
upload_realm_logo_or_icon = f;
};
override_rewire(dropdown_widget, "DropdownWidget", () => ({
setup: noop,
render: noop,
}));
override_rewire(settings_org, "init_dropdown_widgets", noop);
$("#id_realm_message_content_edit_limit_minutes").set_parent(
$.create("<stub edit limit custom input parent>"),
);