report: Provide user information for browser-side errors.

b4dd118aa1 changed how the `user_info_str` parsed information out of
the events it received -- but only changed the server errors, not the
browser errors, though both use the same codepath.  As a result, all
browser errors since then have been incorrectly marked as being for
anonymous users.

Build and pass in the expected `user` dict into the event.

zerver/lib/error_notify.py

@@ -81,9 +81,8 @@ Deployed version: {version}
 
 
 def zulip_browser_error(report: Dict[str, Any], error_bot_email: str) -> None:
-    email_subject = "JS error: {user_email}".format(**report)
-
     user_info = user_info_str(report)
+    email_subject = f"JS error: {user_info}"
 
     body = f"User: {user_info}\n"
     body += "Message: {message}\n".format(**report)

zerver/tests/test_report.py

@@ -164,7 +164,7 @@ class TestReport(ZulipTestCase):
             self.assertEqual(report[k], params[k])
 
         self.assertEqual(report["more_info"], dict(foo="bar", draft_content="'**xxxxx**'"))
-        self.assertEqual(report["user_email"], user.delivery_email)
+        self.assertEqual(report["user"]["user_email"], user.delivery_email)
 
         # Test with no more_info
         del params["more_info"]

zerver/views/report.py

@@ -157,11 +157,13 @@ def report_error(
         more_info["draft_content"] = privacy_clean_markdown(more_info["draft_content"])
 
     if maybe_user_profile.is_authenticated:
-        email = maybe_user_profile.delivery_email
-        full_name = maybe_user_profile.full_name
+        user = {
+            "user_email": maybe_user_profile.delivery_email,
+            "user_full_name": maybe_user_profile.full_name,
+            "user_role": maybe_user_profile.get_role_name(),
+        }
     else:
-        email = "unauthenticated@example.com"
-        full_name = "Anonymous User"
+        user = None
 
     queue_json_publish(
         "error_reports",
@@ -170,8 +172,7 @@ def report_error(
             report=dict(
                 host=SplitResult("", request.get_host(), "", "", "").hostname,
                 ip_address=remote_ip,
-                user_email=email,
-                user_full_name=full_name,
+                user=user,
                 user_visible=ui_message,
                 server_path=settings.DEPLOY_ROOT,
                 version=version,