paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-17 12:21:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove send_times_log feature.

Browse Source 
We no longer use this in development.
This commit is contained in:
Steve Howell
2017-07-30 06:44:46 -04:00
committed by Tim Abbott
parent 41f37d0a6f
commit 90c5b53da3
3 changed files with 0 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
frontend_tests/node_tests/compose.js
View File

@@ -261,8 +261,6 @@ people.add(bob);
$("#send-status").show(); $("#send-status").show();
$("#compose-send-button").attr('disabled', 'disabled'); $("#compose-send-button").attr('disabled', 'disabled');
$("#sending-indicator").show(); $("#sending-indicator").show();
global.feature_flags.log_send_times = true;
global.feature_flags.collect_send_times = true;
var set_timeout_called = false; var set_timeout_called = false;
global.patch_builtin('setTimeout', function (func, delay) { global.patch_builtin('setTimeout', function (func, delay) {
assert.equal(delay, 5000); assert.equal(delay, 5000);

8
static/js/compose.js
View File

@@ -211,7 +211,6 @@ function send_message_socket(request, success, error) {
}); });
} }
exports.send_times_log = [];
exports.send_times_data = {}; exports.send_times_data = {};
function maybe_report_send_times(message_id) { function maybe_report_send_times(message_id) {
var data = exports.send_times_data[message_id]; var data = exports.send_times_data[message_id];
@@ -258,13 +257,6 @@ exports.report_as_received = function report_as_received(message) {
function process_send_time(message_id, start_time, locally_echoed) { function process_send_time(message_id, start_time, locally_echoed) {
var send_finished = new Date(); var send_finished = new Date();
var send_time = (send_finished - start_time);
if (feature_flags.log_send_times) {
blueslip.log("send time: " + send_time);
}
if (feature_flags.collect_send_times) {
exports.send_times_log.push(send_time);
}
if (exports.send_times_data[message_id] === undefined) { if (exports.send_times_data[message_id] === undefined) {
exports.send_times_data[message_id] = {}; exports.send_times_data[message_id] = {};
} }

4
static/js/feature_flags.js
View File

@@ -2,10 +2,6 @@ var feature_flags = (function () {
var exports = {}; var exports = {};
// Manually-flipped debugging flags
exports.log_send_times = false;
exports.collect_send_times = false;
// Experimental modification to support much wider message views. // Experimental modification to support much wider message views.
exports.full_width = false; exports.full_width = false;