paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-05 06:23:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

tools: Rename force argument to skip-provision-check

Browse Source 
This commit renames --force argument used with various tests to
--skip-provision-check. As a consequence of this name change all other
files that set --force option for the test commands have been updated.

This change is done in order to provide more clarity for using this
option for runnning tests.

This commit addresses issue #17455.
This commit is contained in:
m-e-l-u-h-a-n
2021-03-03 01:29:19 +05:30
committed by Tim Abbott
parent ca515e5583
commit 911c5f19f1
13 changed files with 30 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tools/lib/test_server.py
View File

@@ -53,7 +53,7 @@ def server_is_up(server: "subprocess.Popen[bytes]", log_file: Optional[str]) ->
@contextmanager
def test_server_running(
force: bool = False,
skip_provision_check: bool = False,
external_host: str = "testserver",
log_file: Optional[str] = None,
dots: bool = False,
@@ -72,8 +72,8 @@ def test_server_running(
# Run this not through the shell, so that we have the actual PID.
run_dev_server_command = ["tools/run-dev.py", "--test", "--streamlined"]
if force:
run_dev_server_command.append("--force")
if skip_provision_check:
run_dev_server_command.append("--skip-provision-check")
server = subprocess.Popen(run_dev_server_command, stdout=log, stderr=log)
try: