paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 04:53:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

modals: Move "About Zulip" modal from ".app" div to body.

Browse Source 
The "About Zulip" modal should be appended to the body, like the other
modals and not inside the ".app" div.

This is a prep commit for #27550.
This commit is contained in:
Sayam Samal
2023-11-08 23:29:33 +05:30
committed by Tim Abbott
parent 4416f2002b
commit 929d34ccd7
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
templates/zerver/app/index.html
View File

@@ -159,6 +159,8 @@
<div id="user-profile-modal-holder"></div>
<div id="about-zulip-modal-container"></div>
<audio id="user-notification-sound-audio">
<source class="notification-sound-source-ogg" type="audio/ogg" />
<source class="notification-sound-source-mp3" type="audio/mpeg" />

2
web/src/about_zulip.ts
View File

@@ -36,5 +36,5 @@ export function initialize(): void {
page_params.zulip_merge_base &&
page_params.zulip_merge_base !== page_params.zulip_version,
});
$(".app").append(rendered_about_zulip);
$("#about-zulip-modal-container").append(rendered_about_zulip);
}