emoji refactor: Pass in emoji_codes from ui_init.

We don't want emoji.js to depend on a JSON file
(and specifically the location of said JSON file)
when we start sharing our code with mobile.

frontend_tests/node_tests/dispatch.js

@@ -89,6 +89,11 @@ people.add_active_user(test_user);
 
 message_store.add_message_metadata(test_message);
 
+const realm_emoji = {};
+const emoji_codes = zrequire("emoji_codes", "generated/emoji/emoji_codes.json");
+
+emoji.initialize({realm_emoji, emoji_codes});
+
 function assert_same(actual, expected) {
     // This helper prevents us from getting false positives
     // where actual and expected are both undefined.

frontend_tests/node_tests/emoji.js

@@ -1,13 +1,15 @@
+const emoji_codes = zrequire("emoji_codes", "generated/emoji/emoji_codes.json");
+
 const events = require("./lib/events.js");
 
 zrequire("emoji");
 
-const realm_emojis = events.fixtures.realm_emoji.realm_emoji;
+const realm_emoji = events.fixtures.realm_emoji.realm_emoji;
 
-emoji.update_emojis(realm_emojis);
+emoji.initialize({realm_emoji, emoji_codes});
 
 run_test("sanity check", () => {
-    assert.equal(emoji.get_server_realm_emoji_data(), realm_emojis);
+    assert.equal(emoji.get_server_realm_emoji_data(), realm_emoji);
 });
 
 run_test("get_canonical_name", () => {

frontend_tests/node_tests/emoji_picker.js

@@ -1,8 +1,13 @@
 zrequire("emoji");
 zrequire("emoji_picker");
 
+const emoji_codes = zrequire("emoji_codes", "generated/emoji/emoji_codes.json");
+
 run_test("initialize", () => {
-    emoji.update_emojis({});
+    emoji.initialize({
+        realm_emoji: {},
+        emoji_codes,
+    });
     emoji_picker.initialize();
 
     const complete_emoji_catalog = _.sortBy(emoji_picker.complete_emoji_catalog, "name");

frontend_tests/node_tests/hotkey.js

@@ -11,6 +11,8 @@
 // it calls any external module other than `ui.foo`, it'll crash.
 // Future work includes making sure it actually does call `ui.foo()`.
 
+const emoji_codes = zrequire("emoji_codes", "generated/emoji/emoji_codes.json");
+
 set_global("activity", {});
 
 set_global("navigator", {
@@ -26,6 +28,12 @@ set_global("document", "document-stub");
 set_global("$", global.make_zjquery());
 
 zrequire("emoji");
+
+emoji.initialize({
+    realm_emoji: {},
+    emoji_codes,
+});
+
 const hotkey = zrequire("hotkey");
 zrequire("common");
 

frontend_tests/node_tests/markdown.js

@@ -27,6 +27,7 @@ const emoji_params = {
             deactivated: false,
         },
     },
+    emoji_codes,
 };
 
 set_global("page_params", {

frontend_tests/node_tests/reactions.js

@@ -1,6 +1,8 @@
 set_global("document", "document-stub");
 set_global("$", global.make_zjquery());
 
+const emoji_codes = zrequire("emoji_codes", "generated/emoji/emoji_codes.json");
+
 zrequire("emoji");
 zrequire("people");
 zrequire("reactions");
@@ -30,6 +32,7 @@ const emoji_params = {
             deactivated: false,
         },
     },
+    emoji_codes,
 };
 
 emoji.initialize(emoji_params);

static/js/emoji.js

@@ -1,7 +1,8 @@
-const emoji_codes = require("../generated/emoji/emoji_codes.json");
-
 const util = require("./util");
 
+// We will get actual values when we get initialized.
+let emoji_codes = {};
+
 // `emojis_by_name` is the central data source that is supposed to be
 // used by every widget in the webapp for gathering data for displaying
 // emojis. Emoji picker uses this data to derive data for its own use.
@@ -22,7 +23,9 @@ let server_realm_emoji_data = {};
 // We really want to deprecate this, too.
 exports.get_server_realm_emoji_data = () => server_realm_emoji_data;
 
-const emoticon_translations = (() => {
+let emoticon_translations = [];
+
+function build_emoticon_translations() {
     /*
 
     Build a data structure that looks like something
@@ -56,8 +59,8 @@ const emoticon_translations = (() => {
         });
     }
 
-    return translations;
+    emoticon_translations = translations;
-})();
+}
 
 const zulip_emoji = {
     id: "zulip",
@@ -167,6 +170,10 @@ exports.update_emojis = function (realm_emojis) {
 };
 
 exports.initialize = function initialize(params) {
+    emoji_codes = params.emoji_codes;
+
+    build_emoticon_translations();
+
     for (const value of emoji_codes.names) {
         const base_name = exports.get_emoji_codepoint(value);
 

static/js/ui_init.js

@@ -1,3 +1,5 @@
+const generated_emoji_codes = require("../generated/emoji/emoji_codes.json");
+
 const emojisets = require("./emojisets");
 const markdown_config = require("./markdown_config");
 
@@ -448,7 +450,10 @@ exports.initialize_everything = function () {
     bot_data.initialize(bot_params); // Must happen after people.initialize()
     message_fetch.initialize();
     message_scroll.initialize();
-    emoji.initialize(emoji_params);
+    emoji.initialize({
+        realm_emoji: emoji_params.realm_emoji,
+        emoji_codes: generated_emoji_codes,
+    });
     markdown.initialize(page_params.realm_filters, markdown_config.get_helpers());
     compose.initialize();
     composebox_typeahead.initialize(); // Must happen after compose.initialize()