paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Extract can_toggle_subscription(sub).

Browse Source 
We don't want to rely so much on calculated fields,
and the `should_display_subscription_button` name
is a bit misleading in certain contexts.
This commit is contained in:
Steve Howell
2021-04-04 15:23:40 +00:00
committed by Tim Abbott
parent 9c9d74fd6d
commit 93471ed3e4
9 changed files with 16 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
static/js/stream_ui_updates.js
View File

@@ -58,7 +58,7 @@ export function update_settings_button_for_sub(sub) {
} else {
settings_button.text(i18n.t("Subscribe")).addClass("unsubscribed");
}
if (sub.should_display_subscription_button) {
if (stream_data.can_toggle_subscription(sub)) {
settings_button.prop("disabled", false);
settings_button.popover("destroy");
settings_button.css("pointer-events", "");