paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-09 16:37:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

settings: Rename helper function to check who can edit topics.

Browse Source 
This commit renames "can_edit_topic_of_any_message" function
in models.py to "can_move_messages_to_another_topic" and
"user_can_edit_topic_of_any_message" function in settings_data.js
to "user_can_move_messages_to_another_topic".

This change is done since topic editing permission does not
depend on message sender now and messages are considered same
irrespective of whether the user who is editing the topic had sent
the message or not. This also makes the naming consistent with
what we use for the label of this setting in webapp and how we
describe this action in help documentation.
This commit is contained in:
Sahil Batra
2022-10-18 17:18:30 +05:30
committed by Tim Abbott
parent ac96db2d95
commit 939a6edf0f
8 changed files with 17 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
static/js/compose_validate.js
View File

@@ -201,7 +201,7 @@ export function warn_if_topic_resolved(topic_changed) {
return;
}
const button_text = settings_data.user_can_edit_topic_of_any_message()
const button_text = settings_data.user_can_move_messages_to_another_topic()
? $t({defaultMessage: "Unresolve topic"})
: null;