paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-28 02:23:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

compose-closed-ui: Rename update_reply_recipient_label.

Browse Source 
Renames update_reply_recipient_label to
update_recipient_text_for_reply_button.

This better matches the function that sets the default text for
the closed compose box button: set_standard_text_for_reply_button.
This commit is contained in:
Lauryn Menard
2025-03-24 18:14:20 +01:00
committed by Tim Abbott
parent 1b260c9fd7
commit 94fe5fc173
5 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
web/src/compose_closed_ui.ts
View File

@@ -171,7 +171,7 @@ export function set_standard_text_for_reply_button(): void {
set_reply_button_label($t({defaultMessage: "Compose message"})); set_reply_button_label($t({defaultMessage: "Compose message"}));
} }
export function update_reply_recipient_label(message?: ComposeClosedMessage): void { export function update_recipient_text_for_reply_button(message?: ComposeClosedMessage): void {
const recipient_label = get_recipient_label(message); const recipient_label = get_recipient_label(message);
if (recipient_label !== undefined) { if (recipient_label !== undefined) {
const empty_string_topic_display_name = util.get_final_topic_display_name(""); const empty_string_topic_display_name = util.get_final_topic_display_name("");
@@ -194,7 +194,7 @@ export function initialize(): void {
// message_selected events can occur with Recent Conversations // message_selected events can occur with Recent Conversations
// open due to the combined feed view loading in the background, // open due to the combined feed view loading in the background,
// so we only update if message feed is visible. // so we only update if message feed is visible.
update_reply_recipient_label(); update_recipient_text_for_reply_button();
// Disable compose reply button if the selected message is a stream // Disable compose reply button if the selected message is a stream
// message and the user is not allowed to post in the stream the message // message and the user is not allowed to post in the stream the message

2
web/src/inbox_ui.ts
View File

@@ -898,7 +898,7 @@ function update_closed_compose_text($row: JQuery, is_header_row: boolean): void
topic: $row.find(".inbox-topic-name a").text(), topic: $row.find(".inbox-topic-name a").text(),
}; };
} }
compose_closed_ui.update_reply_recipient_label(message); compose_closed_ui.update_recipient_text_for_reply_button(message);
} }
export function get_focused_row_message(): {message?: Message | undefined} & ( export function get_focused_row_message(): {message?: Message | undefined} & (

2
web/src/message_view.ts
View File

@@ -1498,7 +1498,7 @@ function handle_post_view_change(
} else { } else {
compose_closed_ui.update_buttons_for_non_specific_views(); compose_closed_ui.update_buttons_for_non_specific_views();
} }
compose_closed_ui.update_reply_recipient_label(); compose_closed_ui.update_recipient_text_for_reply_button();
message_view_header.render_title_area(); message_view_header.render_title_area();

2
web/src/recent_view_ui.ts
View File

@@ -357,7 +357,7 @@ function set_table_focus(row: number, col: number, using_keyboard = false): bool
topic: $topic_row.find(".recent_topic_name a").text(), topic: $topic_row.find(".recent_topic_name a").text(),
}; };
} }
compose_closed_ui.update_reply_recipient_label(message); compose_closed_ui.update_recipient_text_for_reply_button(message);
return true; return true;
} }

4
web/tests/compose_closed_ui.test.cjs
View File

@@ -150,7 +150,7 @@ run_test("test_custom_message_input", () => {
stream_id: 10, stream_id: 10,
}; };
stream_data.add_sub(stream); stream_data.add_sub(stream);
compose_closed_ui.update_reply_recipient_label({ compose_closed_ui.update_recipient_text_for_reply_button({
stream_id: stream.stream_id, stream_id: stream.stream_id,
topic: "topic test", topic: "topic test",
}); });
@@ -159,7 +159,7 @@ run_test("test_custom_message_input", () => {
run_test("empty_narrow", () => { run_test("empty_narrow", () => {
message_lists.current.visibly_empty = () => true; message_lists.current.visibly_empty = () => true;
compose_closed_ui.update_reply_recipient_label(); compose_closed_ui.update_recipient_text_for_reply_button();
const label = $("#left_bar_compose_reply_button_big").text(); const label = $("#left_bar_compose_reply_button_big").text();
assert.equal(label, "translated: Compose message"); assert.equal(label, "translated: Compose message");
}); });