paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 14:03:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

message_header: Update legacy edit topic button to use icon button.

Browse Source 
This commit is part of a series of commits aimed at updating the message
header buttons to use the new icon button component which has consistent
styling across the Web UI and offers a larger clickable area for the
users.

This commit also replaces the legacy font awesome pencil icon to the
newer "edit" icon from the Zulip font icons.

Fixes part of #34477.
This commit is contained in:
Sayam Samal
2025-05-28 12:40:11 +05:30
committed by Tim Abbott
parent 0f4ba4fec1
commit 9591d05bd7
3 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
web/src/message_list_tooltips.ts
View File

@@ -315,7 +315,10 @@ export function initialize(): void {
}); });
message_list_tooltip( message_list_tooltip(
[
"#message_feed_container .recipient_bar_icon:not(.recipient-row-topic-menu):not(.toggle_resolve_topic_spinner)", "#message_feed_container .recipient_bar_icon:not(.recipient-row-topic-menu):not(.toggle_resolve_topic_spinner)",
"#message_feed_container .recipient-bar-control-icon:not(.recipient-row-topic-menu):not(.toggle_resolve_topic_spinner)",
].join(","),
{ {
delay: LONG_HOVER_DELAY, delay: LONG_HOVER_DELAY,
onHidden(instance) { onHidden(instance) {

1
web/styles/message_header.css
View File

@@ -283,7 +283,6 @@
} }
} }
.on_hover_topic_edit,
.on_hover_topic_unresolve, .on_hover_topic_unresolve,
.on_hover_topic_resolve { .on_hover_topic_resolve {
opacity: 0.2; opacity: 0.2;

2
web/templates/recipient_row.hbs
View File

@@ -47,7 +47,7 @@
{{! edit topic pencil icon }} {{! edit topic pencil icon }}
{{#if is_topic_editable}} {{#if is_topic_editable}}
<i class="fa fa-pencil on_hover_topic_edit recipient-bar-control recipient_bar_icon hidden-for-spectators" data-tippy-content="{{t 'Edit topic'}}" role="button" tabindex="0" aria-label="{{t 'Edit topic' }}"></i> {{> components/icon_button icon="edit" intent="neutral" custom_classes="on_hover_topic_edit recipient-bar-control recipient-bar-control-icon hidden-for-spectators" data-tippy-content=(t "Edit topic") aria-label=(t "Edit topic") }}
{{/if}} {{/if}}
{{#if (and user_can_resolve_topic (not is_empty_string_topic))}} {{#if (and user_can_resolve_topic (not is_empty_string_topic))}}