paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-07 07:23:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

ui_init: Restore guard against direct use of page_params.state_data.

Browse Source 
Before commit fd253539e0 (#30519), each
part of state_data was removed by pop_fields, to ensure that it was
only used by its associated module and not manipulated directly.
Restore this guarantee by removing page_params.state_data itself.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg
2024-06-22 23:34:06 -07:00
committed by Tim Abbott
parent 3a7f5da717
commit 95a2ce6ed6
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
web/src/ui_init.js
View File

@@ -670,7 +670,7 @@ export function initialize_everything(state_data) {
$("#app-loading").addClass("loaded"); $("#app-loading").addClass("loaded");
} }
$(async () => { $(() => {
if (page_params.is_spectator) { if (page_params.is_spectator) {
const data = { const data = {
apply_markdown: true, apply_markdown: true,
@@ -699,7 +699,9 @@ $(async () => {
}, },
}); });
} else { } else {
assert(page_params.state_data !== undefined); const state_data = page_params.state_data;
initialize_everything(page_params.state_data); assert(state_data !== null);
page_params.state_data = null;
initialize_everything(state_data);
} }
}); });