paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-31 12:03:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

tests: Avoid deprecated TestCase method aliases.

Browse Source 
Fixes these warnings with python -Wd:

/home/circleci/zulip/zerver/tests/test_middleware.py:43: DeprecationWarning: Please use assertRegex instead.
  self.assertRegexpMatches(
/home/circleci/zulip/zerver/webhooks/travis/tests.py:40: DeprecationWarning: Please use assertNotEqual instead.
  self.assertNotEquals(msg.topic_name(), self.TOPIC)

https://docs.python.org/3/library/unittest.html#deprecated-aliases

Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg
2020-06-03 18:04:07 -07:00
committed by Tim Abbott
parent c618b3ae30
commit 95f29b5409
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
zerver/tests/test_middleware.py
View File

@@ -40,7 +40,7 @@ class SlowQueryTest(ZulipTestCase):
mock_normal_logger.info.assert_called_once() mock_normal_logger.info.assert_called_once()
logged_line = mock_slow_query_logger.info.call_args_list[0][0][0] logged_line = mock_slow_query_logger.info.call_args_list[0][0][0]
self.assertRegexpMatches( self.assertRegex(
logged_line, logged_line,
r"123\.456\.789\.012 GET 200 10\.\ds .* \(unknown via \?\)" r"123\.456\.789\.012 GET 200 10\.\ds .* \(unknown via \?\)"
) )

2
zerver/webhooks/travis/tests.py
View File

@@ -37,7 +37,7 @@ class TravisHookTests(WebhookTestCase):
) )
self.assert_json_success(result) self.assert_json_success(result)
msg = self.get_last_message() msg = self.get_last_message()
self.assertNotEquals(msg.topic_name(), self.TOPIC) self.assertNotEqual(msg.topic_name(), self.TOPIC)
def test_travis_pull_requests_are_not_ignored_when_applicable(self) -> None: def test_travis_pull_requests_are_not_ignored_when_applicable(self) -> None:
self.url = "{}&ignore_pull_requests=false".format(self.build_webhook_url()) self.url = "{}&ignore_pull_requests=false".format(self.build_webhook_url())