paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

community_topic_edit: Increase time limit to 3 days.

Browse Source 
24hrs is a small time in an asynchronous conversation. Increased
time limit of topic editing for non-admins to 3 days.
This commit is contained in:
Aman Agrawal
2021-01-05 05:22:08 +00:00
committed by Tim Abbott
parent 18bd2469fa
commit 961d1d0a68
6 changed files with 15 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
docs/overview/changelog.md
View File

@@ -27,6 +27,7 @@ in bursts.
#### Full feature changelog #### Full feature changelog
- Community topic editing time limit increased to 3 days for members.
- Removed HipChat import tool. - Removed HipChat import tool.
- Added support for moving topics to private streams. - Added support for moving topics to private streams.
- Added support for subscribing another stream's membership to a stream. - Added support for subscribing another stream's membership to a stream.

4
frontend_tests/node_tests/message_edit.js
View File

@@ -7,7 +7,7 @@ const {run_test} = require("../zjsunit/test");
set_global("document", null); set_global("document", null);
set_global("page_params", { set_global("page_params", {
realm_community_topic_editing_limit_seconds: 86400, realm_community_topic_editing_limit_seconds: 259200,
}); });
stub_out_jquery(); stub_out_jquery();
@@ -92,7 +92,7 @@ run_test("get_editability", () => {
realm_allow_community_topic_editing: true, realm_allow_community_topic_editing: true,
realm_allow_message_editing: true, realm_allow_message_editing: true,
realm_message_content_edit_limit_seconds: 0, realm_message_content_edit_limit_seconds: 0,
realm_community_topic_editing_limit_seconds: 86400, realm_community_topic_editing_limit_seconds: 259200,
is_admin: false, is_admin: false,
}); });
message.timestamp = current_timestamp - 60; message.timestamp = current_timestamp - 60;

6
templates/zerver/api/changelog.md
View File

@@ -10,6 +10,12 @@ below features are supported.
## Changes in Zulip 4.0 ## Changes in Zulip 4.0
**Feature level 38**
* [`POST /register`](/api/register-queue): Increased
`realm_community_topic_editing_limit_seconds` time limit value
to 259200s (3 days).
**Feature level 37** **Feature level 37**
* Consistently provide `subscribers` in stream data when * Consistently provide `subscribers` in stream data when

4
templates/zerver/help/community-topic-edits.md
View File

@@ -4,7 +4,9 @@
By default, anyone can edit any message topic. This is useful because it By default, anyone can edit any message topic. This is useful because it
allows the community to keep conversations organized, even if some members allows the community to keep conversations organized, even if some members
are still learning how to use topics effectively. are still learning how to use topics effectively. Note that non-admin members
cannot edit topic of a message after 3 days even if community topic editing
is enabled.
Organization administrators can turn off community topic editing. Note that Organization administrators can turn off community topic editing. Note that
users may still be able to edit the topic of messages with **(no topic)**; see users may still be able to edit the topic of messages with **(no topic)**; see

2
zerver/models.py
View File

@@ -321,7 +321,7 @@ class Realm(models.Model):
# Whether users have access to message edit history # Whether users have access to message edit history
allow_edit_history: bool = models.BooleanField(default=True) allow_edit_history: bool = models.BooleanField(default=True)
DEFAULT_COMMUNITY_TOPIC_EDITING_LIMIT_SECONDS = 86400 DEFAULT_COMMUNITY_TOPIC_EDITING_LIMIT_SECONDS = 259200
allow_community_topic_editing: bool = models.BooleanField(default=True) allow_community_topic_editing: bool = models.BooleanField(default=True)
# Defaults for new users # Defaults for new users

4
zerver/tests/test_message_edit.py
View File

@@ -633,8 +633,8 @@ class EditMessageTest(ZulipTestCase):
self.login('cordelia') self.login('cordelia')
do_edit_message_assert_error(id_, 'D', "Your organization has turned off message editing") do_edit_message_assert_error(id_, 'D', "Your organization has turned off message editing")
# non-admin users cannot edit topics sent > 24 hrs ago # non-admin users cannot edit topics sent > 72 hrs ago
message.date_sent = message.date_sent - datetime.timedelta(seconds=90000) message.date_sent = message.date_sent - datetime.timedelta(seconds=290000)
message.save() message.save()
self.login('iago') self.login('iago')
set_message_editing_params(True, 0, True) set_message_editing_params(True, 0, True)