paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-01 04:23:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

message_edit: Display the error banners in the correct place.

Browse Source 
Fixes: #25412.
This commit is contained in:
Daniil Fadeev
2023-05-03 22:43:01 +07:00
committed by Tim Abbott
parent 0756ac9250
commit 96680e95fb
2 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
web/src/message_edit.js
View File

@@ -12,6 +12,7 @@ import * as blueslip from "./blueslip";
import * as channel from "./channel"; import * as channel from "./channel";
import * as compose from "./compose"; import * as compose from "./compose";
import * as compose_actions from "./compose_actions"; import * as compose_actions from "./compose_actions";
import * as compose_banner from "./compose_banner";
import * as compose_ui from "./compose_ui"; import * as compose_ui from "./compose_ui";
import * as composebox_typeahead from "./composebox_typeahead"; import * as composebox_typeahead from "./composebox_typeahead";
import * as condense from "./condense"; import * as condense from "./condense";
@@ -967,11 +968,15 @@ export function save_message_row_edit($row) {
} }
hide_message_edit_spinner($row); hide_message_edit_spinner($row);
const message = channel.xhr_error_message( const message = channel.xhr_error_message(null, xhr);
$t({defaultMessage: "Error saving edit"}), const $container = compose_banner.get_compose_banner_container(
xhr, $row.find("textarea"),
);
compose_banner.show_error_message(
message,
compose_banner.CLASSNAMES.generic_compose_error,
$container,
); );
$row.find(".edit_error").text(message).show();
} }
}, },
}); });

1
web/templates/message_edit_form.hbs
View File

@@ -43,5 +43,4 @@
{{/if}} {{/if}}
</div> </div>
</div> </div>
<div class="alert alert-error edit_error hide"></div>
</form> </form>