From 96a50422f7a80d822b4de358461ecbb80d34d4b9 Mon Sep 17 00:00:00 2001
From: showell <showell@zulipchat.com>
Date: Mon, 6 Jan 2020 15:30:00 -0500
Subject: [PATCH] minor: Avoid recip.user_id defensive fallback.

The recip.id || recip.user_id idiom has only been
needed for some old unit tests.

It was previously required as a bad workaround for the
local echo issue fixed in dd1a6a97bdac0fc70422c74a82c4cbd268be6eff
where we would get `display_recipient` values added in an invalid format.
---
 static/js/message_store.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/static/js/message_store.js b/static/js/message_store.js
index c50914516f..17cf8a397b 100644
--- a/static/js/message_store.js
+++ b/static/js/message_store.js
@@ -179,7 +179,7 @@ exports.add_message_metadata = function (message) {
 
         if (people.is_my_user_id(message.sender_id)) {
             _.each(message.display_recipient, (recip) => {
-                message_user_ids.add(recip.id || recip.user_id);
+                message_user_ids.add(recip.id);
             });
         }
         break;