paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 15:03:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

message_list_view: Clarify imprecise performance comment.

Browse Source 
A single call to this function doesn't have a material performance
impact when tested with 20k messages while scrolling in combined feed
view; likely because only 400 messages can be in the structure at any
give time given render windows.

But calling this in a loop somewhere would be a bad idea.
This commit is contained in:
Aman Agrawal
2024-04-22 04:56:16 +00:00
committed by Tim Abbott
parent 2d824e85cc
commit 9702ff3539
1 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
web/src/message_list_view.js
View File

@@ -1265,12 +1265,11 @@ export class MessageListView {
} }
_find_message_group(message_group_id) { _find_message_group(message_group_id) {
// Ideally, we'd maintain this data structure with a hash // Finds the message group with a given message group ID.
// table or at least a pointer from the message containers (in //
// either case, updating the data structure when message // This function does a linear search, so be careful to avoid
// groups are merged etc.), but we only call this from flows // calling it in a loop. If you need that, we'll need to add a
// like message editing, so it's not a big performance // hash table to make this O(1) runtime.
// problem.
return this._message_groups.find( return this._message_groups.find(
// Since we don't have a way to get a message group from // Since we don't have a way to get a message group from
// the containing message container, we just do a search // the containing message container, we just do a search