paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-09 08:26:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

settings org: Deduplicate upload_realm_logo_or_icon.

Browse Source 
Now that we have arranged our HTML and CSS classes in a similar
fashion for each of the cases, we can remove the duplicated lists of
objects.
This commit is contained in:
jagansivam28
2020-06-17 11:32:33 +05:30
committed by Tim Abbott
parent 548107632c
commit 97b992323c
1 changed files with 8 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
static/js/settings_org.js
View File

@@ -944,10 +944,7 @@ exports.build_page = function () {
function upload_realm_logo_or_icon(file_input, night, icon) { function upload_realm_logo_or_icon(file_input, night, icon) {
const form_data = new FormData(); const form_data = new FormData();
let spinner; let widget;
let error_field;
let upload_text;
let delete_button;
let url; let url;
form_data.append('csrfmiddlewaretoken', csrf_token); form_data.append('csrfmiddlewaretoken', csrf_token);
@@ -956,29 +953,20 @@ exports.build_page = function () {
} }
if (icon) { if (icon) {
url = '/json/realm/icon'; url = '/json/realm/icon';
spinner = $('#realm-icon-upload-widget .upload-spinner-background'); widget = '#realm-icon-upload-widget';
upload_text = $('#realm-icon-upload-widget .settings-page-upload-text');
delete_button = $('#realm-icon-upload-widget .settings-page-delete-button');
error_field = $("#realm-icon-upload-widget .image_file_input_error");
} else { } else {
if (night) { if (night) {
error_field = $("#realm-night-logo-upload-widget .image_file_input_error"); widget = '#realm-night-logo-upload-widget';
spinner = $("#realm-night-logo-upload-widget .upload-spinner-background");
upload_text = $('#realm-night-logo-upload-widget .settings-page-upload-text');
delete_button = $('#realm-night-logo-upload-widget .settings-page-delete-button');
} else { } else {
error_field = $("#realm-day-logo-upload-widget .image_file_input_error"); widget = '#realm-day-logo-upload-widget';
spinner = $("#realm-day-logo-upload-widget .upload-spinner-background");
upload_text = $('#realm-day-logo-upload-widget .settings-page-upload-text');
delete_button = $('#realm-day-logo-upload-widget .settings-page-delete-button');
} }
url = '/json/realm/logo'; url = '/json/realm/logo';
form_data.append('night', JSON.stringify(night)); form_data.append('night', JSON.stringify(night));
} }
spinner.expectOne(); const spinner = $(`${widget} .upload-spinner-background`).expectOne();
upload_text.expectOne(); const upload_text = $(`${widget} .settings-page-upload-text`).expectOne();
delete_button.expectOne(); const delete_button = $(`${widget} .settings-page-delete-button`).expectOne();
error_field.expectOne(); const error_field = $(`${widget} .image_file_input_error`).expectOne();
realm_icon_logo_upload_start(spinner, upload_text, delete_button); realm_icon_logo_upload_start(spinner, upload_text, delete_button);
error_field.hide(); error_field.hide();
channel.post({ channel.post({