paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-30 19:43:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

settings_account: Don't redirect to login page during password change.

Browse Source 
This handles a rare race condition that occurs when the session hash
is not updated by the backend during the password change process.
This mostly occurs in puppeteer tests, but could occur to a user.
This commit is contained in:
Priyank Patel
2020-08-25 16:37:48 +00:00
committed by Tim Abbott
parent 5548ab8b99
commit 9884226ffb
3 changed files with 32 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
static/js/setup.js
View File

@@ -1,8 +1,9 @@
"use strict";
const util = require("./util");
// Miscellaneous early setup.
// Miscellaneous early setup.
exports.password_change_in_progress = false;
$(() => {
if (util.is_mobile()) {
// Disable the tutorial; it's ugly on mobile.
@@ -35,10 +36,23 @@ $(() => {
// For some reason, jQuery wants this to be attached to an element.
$(document).ajaxError((event, xhr) => {
if (exports.password_change_in_progress) {
// The backend for handling password change API requests
// will replace the user's session; this results in a
// brief race where any API request will fail with a 401
// error after the old session is deactivated but before
// the new one has been propagated to the browser. So we
// skip our normal HTTP 401 error handling if we're in the
// process of executing a password change.
return;
}
if (xhr.status === 401) {
// We got logged out somehow, perhaps from another window or a session timeout.
// We could display an error message, but jumping right to the login page seems
// smoother and conveys the same information.
// We got logged out somehow, perhaps from another window
// changing the user's password, or a session timeout. We
// could display an error message, but jumping right to
// the login page conveys the same information with a
// smoother re-login experience.
window.location.replace(page_params.login_page);
}
});