paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 04:53:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

message_events: Reorganize code to insert new messages.

Browse Source 
This commit makes it a bit more explicit about
why we're updating 2 or 3 message lists every time.

It looks funny now to repeat the home-list updates
in both sides of the conditional, but this will be
more obvious in a subsequent commit, where we want
to capture return values from rendering.
This commit is contained in:
Steve Howell
2019-01-07 20:40:03 +00:00
committed by Tim Abbott
parent ed0abb8a53
commit 9893256668
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
static/js/message_events.js
View File

@@ -64,16 +64,24 @@ exports.insert_new_messages = function insert_new_messages(messages, locally_ech
unread.process_loaded_messages(messages);
message_util.add_messages(messages, home_msg_list, {messages_are_new: true});
// message_list.all is a data-only list that we use to populate
// other lists, so we always update this
message_util.add_messages(messages, message_list.all, {messages_are_new: true});
if (narrow_state.active()) {
// We do this NOW even though the home view is not active,
// because we want the home view to load fast later.
message_util.add_messages(messages, home_msg_list, {messages_are_new: true});
if (narrow_state.filter().can_apply_locally()) {
message_util.add_messages(messages, message_list.narrowed, {messages_are_new: true});
} else {
// if we cannot apply locally, we have to wait for this callback to happen to notify
maybe_add_narrowed_messages(messages, message_list.narrowed, true);
}
} else {
// we're in the home view, so update its list
message_util.add_messages(messages, home_msg_list, {messages_are_new: true});
}