paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-01 04:23:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

org settings: Fix a bug where the loading spinner was not visible.

Browse Source 
In Chrome, the loading spinners on the Bots and Deactivated Users pages
were not visible due to the `filter` elements having duplicate IDs across
the different pages. (There are multiple `filter` elements with the ID
`uil-ring-shadow` on the page.)

To solve this, when generating a new loading SVG element, we append
the container element's ID to the filter's ID, thus preventing any
duplicates.

Fix #8620.
This commit is contained in:
Marco Burstein
2018-08-07 16:41:09 -07:00
committed by Tim Abbott
parent 14bc5c7d5c
commit 995d073dbf
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
static/js/loading.js
View File

@@ -29,7 +29,7 @@ exports.make_indicator = function (outer_container, opts) {
}
var spinner_elem = $('<div class="loading_indicator_spinner"></div>');
spinner_elem.html(templates.render("loader"));
spinner_elem.html(templates.render("loader", { container_id: outer_container.attr("id") }));
container.append(spinner_elem);
var text_width = 0;