paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

test_bots: Add coverage for no-op changes to bot owner.

Browse Source 
This isn't a complete long-term fix, in that ideally we'd be doing
this check at the view layer, but various structural things make that
annoying, and we'll want this test either way.
This commit is contained in:
Tim Abbott
2018-05-22 15:03:31 -07:00
parent 1b47b2e7cd
commit 998e1048e8
1 changed files with 17 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
zerver/tests/test_bots.py
View File

@@ -766,6 +766,23 @@ class BotTest(ZulipTestCase, UploadSerializeMixin):
profile = self.get_bot_user(email) profile = self.get_bot_user(email)
self.assertEqual(profile.bot_owner, self.example_user("hamlet")) self.assertEqual(profile.bot_owner, self.example_user("hamlet"))
def test_patch_bot_owner_noop(self) -> None:
self.login(self.example_email('hamlet'))
self.create_bot()
self.assert_num_bots_equal(1)
bot_info = {
'bot_owner': self.example_email('hamlet'),
}
email = 'hambot-bot@zulip.testserver'
result = self.client_patch("/json/bots/{}".format(self.get_bot_user(email).id), bot_info)
# Check that we're still the owner
self.assert_json_success(result)
profile = self.get_bot_user(email)
self.assertEqual(profile.bot_owner, self.example_user("hamlet"))
def test_patch_bot_owner_a_bot(self) -> None: def test_patch_bot_owner_a_bot(self) -> None:
self.login(self.example_email('hamlet')) self.login(self.example_email('hamlet'))
self.create_bot() self.create_bot()