paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-31 20:13:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

widgets: Clean up index handling.

Browse Source 
We only need to bump up indexes if inbound
events suggest that we have incremented our
personal index from another device.

We don't want somebody else's runaway index
to affect our index.

(For both widgets the sender_id is part of
the key, so uniqueness across all senders is
not required for the integer part.)
This commit is contained in:
Steve Howell
2021-06-13 13:14:07 +00:00
committed by Tim Abbott
parent 91b8049ecf
commit 99cdfbcbe5
2 changed files with 10 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
static/js/todo_widget.js
View File

@@ -9,16 +9,7 @@ import * as util from "./util";
export class TaskData {
task_map = new Map();
get_new_index() {
let idx = 0;
for (const item of this.task_map.values()) {
idx = Math.max(idx, item.idx);
}
return idx + 1;
}
my_idx = 1;
get_widget_data() {
const all_tasks = Array.from(this.task_map.values());
@@ -56,9 +47,10 @@ export class TaskData {
handle = {
new_task: {
outbound: (task, desc) => {
this.my_idx += 1;
const event = {
type: "new_task",
key: this.get_new_index(),
key: this.my_idx,
task,
desc,
completed: false,
@@ -91,6 +83,11 @@ export class TaskData {
if (!this.name_in_use(task)) {
this.task_map.set(key, task_data);
}
// I may have added a task from another device.
if (sender_id === this.me && this.my_idx <= idx) {
this.my_idx = idx + 1;
}
},
},