paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 13:03:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

api: Fix encoding of strings in display settings endpoint.

Browse Source 
* Remove unnecessary json validator for string validator.
* Update frontend to pass right validator.
* Update zulip.yaml to pass right parameter for curl request
  in openapi.
* Update python_examples to pass right paramater.

Fixes part of #18035.
This commit is contained in:
Gaurav Pandey
2021-05-08 21:06:47 +05:30
committed by Tim Abbott
parent 544bbd5398
commit 9abe1cafbe
5 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
zerver/tests/test_settings.py
View File

@@ -354,7 +354,7 @@ class ChangeSettingsTest(ZulipTestCase):
else:
invalid_value = "invalid_" + setting_name
if setting_name == "default_language":
if setting_name not in ["demote_inactive_streams", "color_scheme"]:
data = {setting_name: test_value}
else:
data = {setting_name: orjson.dumps(test_value).decode()}
@@ -366,7 +366,7 @@ class ChangeSettingsTest(ZulipTestCase):
# Test to make sure invalid settings are not accepted
# and saved in the db.
if setting_name == "default_language":
if setting_name not in ["demote_inactive_streams", "color_scheme"]:
data = {setting_name: invalid_value}
else:
data = {setting_name: orjson.dumps(invalid_value).decode()}
@@ -389,7 +389,7 @@ class ChangeSettingsTest(ZulipTestCase):
def do_change_emojiset(self, emojiset: str) -> HttpResponse:
self.login("hamlet")
data = {"emojiset": orjson.dumps(emojiset).decode()}
data = {"emojiset": emojiset}
result = self.client_patch("/json/settings/display", data)
return result