paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-08 07:52:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

buddy_list: Fetch *all* subscribers for small channels in big orgs.

Browse Source 
Followup to #31645. I tweaked the filter in `maybe_shrink_list`, but
that function works with user ids originally fetched in
`get_filtered_user_id_list`, which was only fetching ids of users
that had been recently active.
This commit is contained in:
evykassirer
2024-09-21 14:55:49 -07:00
committed by Tim Abbott
parent f12ffadfbc
commit 9b8df679d7
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
web/src/buddy_data.ts
View File

@@ -382,6 +382,17 @@ function get_filtered_user_id_list(user_filter_text: string): number[] {
const base_user_id_set = new Set([...base_user_id_list, ...pm_ids_set]); const base_user_id_set = new Set([...base_user_id_list, ...pm_ids_set]);
base_user_id_list = [...base_user_id_set]; base_user_id_list = [...base_user_id_set];
} }
// We want to show subscribers even if they're inactive, if there are few
// enough subscribers in the channel.
const stream_id = narrow_state.stream_id();
if (stream_id) {
const subscribers = peer_data.get_subscribers(stream_id);
if (subscribers.length <= max_channel_size_to_show_all_subscribers) {
const base_user_id_set = new Set([...base_user_id_list, ...subscribers]);
base_user_id_list = [...base_user_id_set];
}
}
} }
const user_ids = filter_user_ids(user_filter_text, base_user_id_list); const user_ids = filter_user_ids(user_filter_text, base_user_id_list);