paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

emoji picker: Move cursor to end of filter string when focusing.

Browse Source 
This is a much less annoying behavior than the Chrome browser default.

Explanatory comment added by tabbott, thanks to Steve Howell for the
research.

Fixes #4604.
This commit is contained in:
Tejas Kasetty
2017-05-05 22:08:14 +05:30
committed by Tim Abbott
parent 235d06e7e5
commit 9b9c323314
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
static/js/reactions.js
View File

@@ -177,8 +177,15 @@ exports.reaction_navigate = function (e, event_name) {
$(first_emoji).focus(); $(first_emoji).focus();
} }
} else if (event_name === 'up_arrow') { } else if (event_name === 'up_arrow') {
if (selected_emoji && selected_index < 6) { // move up into reaction filter if (selected_emoji && selected_index < 6) {
$('.emoji-popover-filter').focus(); // In this case, we're move up into the reaction filter
// rows. Here, we override the default browser behavior,
// which in Firefox is good (preserving the cursor
// position) and in Chrome is bad (cursor goes to
// beginning) with something reasonable and consistent
// (cursor goes to the end of the filter string).
$('.emoji-popover-filter').focus().caret(Infinity);
return true;
} }
} }