paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-18 04:43:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

user_groups: Check can_add_members_group when adding members.

Browse Source 
Fixes #25942.
Users with permission to manage the group (either on the group level or
realm level) should be able to add members to the group without being
present in can_add_members_group.
This commit is contained in:
Shubham Padia
2024-10-09 07:37:35 +00:00
committed by Tim Abbott
parent 8a2a8b64aa
commit 9bbd6a7316
4 changed files with 157 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
web/src/user_group_edit.js
View File

@@ -87,7 +87,7 @@ function update_add_members_elements(group) {
const $input_element = $add_members_container.find(".input").expectOne();
const $button_element = $add_members_container.find('button[name="add_member"]').expectOne();
if (settings_data.can_manage_user_group(group.id)) {
if (settings_data.can_add_members_to_user_group(group.id)) {
$input_element.prop("contenteditable", true);
$button_element.prop("disabled", false);
$button_element.css("pointer-events", "");
@@ -658,6 +658,10 @@ export function update_group(event) {
if (event.data.can_mention_group !== undefined) {
sync_group_permission_setting("can_mention_group", group);
}
if (event.data.can_manage_group !== undefined) {
sync_group_permission_setting("can_add_members_group", group);
update_group_management_ui();
}
if (event.data.can_manage_group !== undefined) {
sync_group_permission_setting("can_manage_group", group);
update_group_management_ui();