paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-11 01:16:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

compose: Replace accidental usage of underscore for “translation”.

Browse Source 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg
2020-07-24 17:56:31 -07:00
committed by Tim Abbott
parent da8691d7d7
commit 9c7a3cc0f4
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
frontend_tests/node_tests/compose.js
View File

@@ -1480,8 +1480,8 @@ run_test("on_events", () => {
handler(ev); handler(ev);
// video link ids consist of 15 random digits // video link ids consist of 15 random digits
let video_link_regex = /\[Click to join video call\]\(https:\/\/meet.jit.si\/\d{15}\)/; let video_link_regex = /\[translated: Click to join video call\]\(https:\/\/meet.jit.si\/\d{15}\)/;
assert(video_link_regex.test(syntax_to_insert)); assert.match(syntax_to_insert, video_link_regex);
page_params.jitsi_server_url = null; page_params.jitsi_server_url = null;
called = false; called = false;
@@ -1505,8 +1505,8 @@ run_test("on_events", () => {
}; };
handler(ev); handler(ev);
video_link_regex = /\[Click to join video call\]\(example\.zoom\.com\)/; video_link_regex = /\[translated: Click to join video call\]\(example\.zoom\.com\)/;
assert(video_link_regex.test(syntax_to_insert)); assert.match(syntax_to_insert, video_link_regex);
page_params.realm_video_chat_provider = page_params.realm_video_chat_provider =
page_params.realm_available_video_chat_providers.big_blue_button.id; page_params.realm_available_video_chat_providers.big_blue_button.id;
@@ -1520,8 +1520,8 @@ run_test("on_events", () => {
}; };
handler(ev); handler(ev);
video_link_regex = /\[Click to join video call\]\(\/calls\/bigbluebutton\/join\?meeting_id=%22zulip-1%22&password=%22AAAAAAAAAA%22&checksum=%2232702220bff2a22a44aee72e96cfdb4c4091752e%22\)/; video_link_regex = /\[translated: Click to join video call\]\(\/calls\/bigbluebutton\/join\?meeting_id=%22zulip-1%22&password=%22AAAAAAAAAA%22&checksum=%2232702220bff2a22a44aee72e96cfdb4c4091752e%22\)/;
assert(video_link_regex.test(syntax_to_insert)); assert.match(syntax_to_insert, video_link_regex);
})(); })();
(function test_markdown_preview_compose_clicked() { (function test_markdown_preview_compose_clicked() {

4
static/js/compose.js
View File

@@ -821,8 +821,8 @@ exports.needs_subscribe_warning = function (user_id, stream_id) {
}; };
function insert_video_call_url(url, target_textarea) { function insert_video_call_url(url, target_textarea) {
const video_call_link_text = "[" + _("Click to join video call") + "](" + url + ")"; const link_text = i18n.t("Click to join video call");
compose_ui.insert_syntax_and_focus(video_call_link_text, target_textarea); compose_ui.insert_syntax_and_focus(`[${link_text}](${url})`, target_textarea);
} }
exports.render_and_show_preview = function (preview_spinner, preview_content_box, content) { exports.render_and_show_preview = function (preview_spinner, preview_content_box, content) {